Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: File drag and drop crash in Grid Layout #14484

Closed
vavacll opened this issue Jan 17, 2024 · 17 comments · Fixed by #14654
Closed

Bug: File drag and drop crash in Grid Layout #14484

vavacll opened this issue Jan 17, 2024 · 17 comments · Fixed by #14654
Labels
crash Bug reports involving a crash help wanted Extra attention is needed needs - winui Requires changes from WinUI

Comments

@vavacll
Copy link

vavacll commented Jan 17, 2024

Description

when I try to drag and drop file it crashes

Steps To Reproduce

2024-01-17.18-40-34.mp4

Requirements

Fix crash that occurs when

  1. I have files layout type on small, medium or large
  2. and I try to drag and drop to another window

Files Version

3.1.1.0

Windows Version

10.0.19045.3930

Log File

debug.log
@vavacll vavacll added the bug label Jan 17, 2024
@Josh65-2201
Copy link
Member

Thanks for the report, can you see if this is an issue in the preview version. https://files.community/download

@Josh65-2201 Josh65-2201 added the needs - additional info Needs more information from the reporter label Jan 17, 2024
@yaira2
Copy link
Member

yaira2 commented Jan 19, 2024

Does this issue occur with the Details layout as well?

@vavacll
Copy link
Author

vavacll commented Jan 21, 2024 via email

@vavacll
Copy link
Author

vavacll commented Jan 21, 2024 via email

@vavacll
Copy link
Author

vavacll commented Jan 22, 2024 via email

@vavacll
Copy link
Author

vavacll commented Jan 22, 2024 via email

@yaira2
Copy link
Member

yaira2 commented Jan 23, 2024

Is there any difference in Preview version v3.1.6?

@yaira2 yaira2 changed the title file drag and drop crash Bug: File drag and drop crash in Grid Layout Jan 23, 2024
@yaira2 yaira2 added the crash Bug reports involving a crash label Jan 23, 2024
@vavacll
Copy link
Author

vavacll commented Jan 23, 2024 via email

@yaira2 yaira2 added help wanted Extra attention is needed and removed needs - additional info Needs more information from the reporter labels Jan 23, 2024
@benji78
Copy link

benji78 commented Jan 27, 2024

This a bug I have had for more than a year, ever since I started using files as my default explorer. I never reported it because I don't have time to test it on another windows machine as mine is heavily de-bloated and customised, I never got anything out of the debug.log file (for this particular kind of crash) and there were may different variations of this bug which seem to have now been fixed.
It never occurred to me that it could be layout dependent as I mostly use tiles and sometimes icons layouts, but it indeed seems that the details and columns layouts are not affected.
However what I found, is that crashes only occur now when crossing or hovering over the status bar at the bottom of the files window, pretty much in the only direction I would want to drag a file to!

@yaira2
Copy link
Member

yaira2 commented Jan 28, 2024

@vavacll can you try to repro this in the latest preview build again? I don't see anything in the log file but hopefully the report will show up in App Center.

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Jan 28, 2024
@benji78
Copy link

benji78 commented Jan 29, 2024 •
edited
Loading

Yes, it still occurs in 1.3.8.0, but I also found out it is only when I set a group by.
(Sorry for replying for OP)

Here is the Event Viewer error report:

Faulting application name: Files.exe, version: 1.0.0.0, time stamp: 0x65680000
Faulting module name: Microsoft.UI.Xaml.dll, version: 3.1.4.0, time stamp: 0x09e901a7
Exception code: 0xc0000005
Fault offset: 0x000000000031c4d8
Faulting process ID: 0x6b10
Faulting application start time: 0x01da52e710c34290
Faulting application path: C:\Program Files\WindowsApps\FilesPreview_3.1.8.0_x64__1y0xx7n9077q4\Files.App\Files.exe
Faulting module path: C:\Program Files\WindowsApps\Microsoft.WindowsAppRuntime.1.4_4000.1082.2259.0_x64__8wekyb3d8bbwe\Microsoft.UI.Xaml.dll
Report ID: 98b34b28-6870-453f-9168-85fde4b4b280
Faulting package full name: FilesPreview_3.1.8.0_x64__1y0xx7n9077q4
Faulting package-relative application ID: App

@yaira2
Copy link
Member

yaira2 commented Jan 29, 2024

This is what I see in AppCenter

WinRT
ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0 (Int32 hr)
ABI.Windows.ApplicationModel.DataTransfer
IDataPackageViewMethods.get_RequestedOperation (IObjectReference _obj)
Files.App.Utils.Storage
FilesystemHelpers.PerformOperationTypeAsync (DataPackageOperation operation, DataPackageView packageView, String destination, Boolean showDialog, Boolean registerHistory, Boolean isTargetExecutable, Boolean isTargetPythonFile)
Files.App.ViewModels.Layouts
BaseLayoutViewModel.DropAsync (DragEventArgs e)
CommunityToolkit.Mvvm.Input
AsyncRelayCommand.AwaitAndThrowIfFailed (Task executionTask)
System.Threading.Tasks.Task
<>c.<ThrowAsync>b__128_0 (Object state)

@vavacll
Copy link
Author

vavacll commented Jan 31, 2024 via email

@yaira2
Copy link
Member

yaira2 commented Jan 31, 2024

I think the report I added above is from this crash.

@yaira2 yaira2 mentioned this issue Feb 4, 2024
Closed
@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label Feb 5, 2024
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Feb 5, 2024
@hishitetsu
Copy link
Member

I can reproduce.
Image

@hishitetsu
Copy link
Member

I believe this is a WinUI 3 issue.
microsoft/microsoft-ui-xaml#9119

@hishitetsu hishitetsu mentioned this issue Feb 6, 2024
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board Feb 6, 2024
@0x5bfa
Copy link
Member

0x5bfa commented Oct 4, 2024

The issue in WinUI seems to have been fixed.

You were right about the needed changes, and they will be part of the next WinUI3 release.

@0x5bfa 0x5bfa added the needs - winui Requires changes from WinUI label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash Bug reports involving a crash help wanted Extra attention is needed needs - winui Requires changes from WinUI
Projects
Files task board
Archived in project
Milestone
No milestone
6 participants
@Josh65-2201 @yaira2 @benji78 @0x5bfa @hishitetsu @vavacll