Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where icons were not displayed on submenus of shell extensions #14070

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Fix: Fixed issue where icons were not displayed on submenus of shell extensions #14070

merged 1 commit into from
Nov 26, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Shell extensions in context menu are missing their icons #3834

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots
image

QuaintMako
QuaintMako approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works on my computer! That looks SO good, thanks for this addition!

src/Files.App/Helpers/MenuFlyout/ItemModelListToContextFlyoutHelper.cs
@@ -109,6 +125,7 @@ private static MenuFlyoutItemBase GetItem(ContextMenuFlyoutItemViewModel i)
Tag = i.Tag,
Command = i.Command,
CommandParameter = i.CommandParameter,
CornerRadius = new(4),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth putting the 4 inside a variable since it's repeated l.94?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a static resource from WinUI we can use.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for MenuFlyoutItemWithImage, not for MenuFlyoutSubItem. You may notice corners are not rounded when hovering over menu items with an icon in current stable or preview release.

I think there is a static resource from WinUI we can use.

I thought so too, but couldn't find it right away.

@yaira2 yaira2 added needs - code review ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 25, 2023
@yaira2 yaira2 merged commit 7eb7437 into files-community:main Nov 26, 2023
6 checks passed
@hishitetsu hishitetsu deleted the MenuFlyoutSubItemWithImage branch November 26, 2023 01:28
@hishitetsu hishitetsu mentioned this pull request Nov 26, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

@QuaintMako QuaintMako QuaintMako approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Shell extensions in context menu are missing their icons
3 participants
@hishitetsu @yaira2 @QuaintMako