Bug: Shell extensions in context menu are missing their icons

[Josh65-2201]

Describe the bug
Custom program icons on the right click menu don't work.

Steps to reproduce

• Install 7zip
• Right click file or folder in Files and observe that 7zip doesn't have an icon
• Right click file or folder in File Explorer and observe that 7zip does have an icon

Requirements

• Icons should be consistent with File Explorer

Current missing ones

• VLC
• 7-zip
• WinRAR
• Google drive
• Avast anti-virus

Desktop (please complete the following information):

• OS Version: Windows 10 20H2 19042.804
• App version: 1.3.0.0

[gave92]

Could you check is this is the same as #3708?
Are icons shown in the first level of the context menu?

[Josh65-2201]

Some are. The screen shots are from the first level of the context menu. 7-zip, Avast and macrium reflect icons don't show up.

[Josh65-2201]

Still an issue with 1.5.46

[Josh65-2201]

Still an issue in 1.9.14. Updated non icon list: 7-zip, Backup and sync, Avast, Macrium reflect, Bit locker (except the c drive)

[gave92]

I'm not sure we can fix this, all uwp file managers seem to have this issue on the same elements.

[Josh65-2201]

Oh disappointing. Could it be fix using the full trust part of files or WinUI?

[Josh65-2201]

Closing due to UWP limitations.

[PavelDobCZ23]

WinRar, Change File Extension and Windows Defender icons are missing for me.

Windows Explorer:

Files:

[yaira2]

@Josh-65 is this still an issue?

[Josh65-2201]

yep

[PavelDobCZ23]

@Josh-65 is this still an issue?

yes

[Josh65-2201]

Currently these, WinRAR based on the screenshot in above comment and avast anti virus (I dont have it anymore but was still missing the time it was uninstalled).

This is what they are in file exploer

[yaira2]

I tried debugging but the API isn't returning the icon, @Josh-65 is this an issue in Explorer++ as well?

[Josh65-2201]

No icons there show the same as File explorer

[hishitetsu]

Icons for items without submenus are displayed by MenuFlyoutItemWithImage class.
https://github.com/files-community/Files/blob/main/src/Files.App/UserControls/Menus/MenuFlyoutItemWithImage.xaml.cs

However, there is no MenuFlyoutSubItemWithImage class, so icons for items with submenus are not displayed.
MenuFlyoutItemWithImage extends MenuFlyoutItem, but MenuFlyoutSubItem is sealed and can't be extended.

[yaira2]

Is there a feature request on the WinUI repo?

[yaira2]

@hishitetsu looking into this further, it appears that we can set a BitmapIcon without extending the class.

[hishitetsu]

@hishitetsu looking into this further, it appears that we can set a BitmapIcon without extending the class.

True, but I thought only static image resources could be used for BitmapIcon?

[hishitetsu]

Yes, they are dynamically retrieved as HBITMAP when the shell extensions are loaded.

[yaira2]

By static, do you mean as opposed to changing the icon after the item is already added to the menu?

[hishitetsu]

I mean resources that can be specified by URI. (like ms-appx://)