Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Remove Async suffix from event methods #13567

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Code Quality: Remove Async suffix from event methods #13567

merged 2 commits into from
Oct 24, 2023

Conversation

A-Loot
Copy link
Contributor

@A-Loot A-Loot commented Oct 24, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

This change was suggested by 0x5bfa in #13554 (comment)

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should've review the previous PR and tell you this before merging. Apologies to have made you revert some changes.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 24, 2023
@yaira2
Copy link
Member

yaira2 commented Oct 24, 2023

Thanks!

@yaira2 yaira2 merged commit 1e8d456 into files-community:main Oct 24, 2023
2 checks passed
@A-Loot A-Loot deleted the no-async-suffix branch October 24, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants