-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Added tooltip to the eject button #13554
Merged
yaira2
merged 5 commits into
files-community:main
from
0x5bfa:5bfa/Add-EjectTooltipOnSideBar
Oct 25, 2023
Merged
Fix: Added tooltip to the eject button #13554
yaira2
merged 5 commits into
files-community:main
from
0x5bfa:5bfa/Add-EjectTooltipOnSideBar
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@yaira2 Ready for review. |
hecksmosis
reviewed
Oct 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that LGTM
yaira2
reviewed
Oct 23, 2023
8 tasks
yaira2
changed the title
Fix: Added the tooltip for the eject button
Fix: Added tooltip to the eject button
Oct 24, 2023
yaira2
previously approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
changes requested
Changes are needed for this pull request
labels
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small fix.
Task Checklist
Known Issues
N/A
PR Checklist
Steps To Validate Changes
N/A
Screenshots
Before
After
Footnotes
If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request. ↩
If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do, instead. ↩