Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added tooltip to the eject button #13554

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Oct 22, 2023

Summary

This is a small fix.

Task Checklist

  • Added the tooltip for the eject button
  • Clean up
  • Apply requested changes

Known Issues

N/A

PR Checklist

  • Closes: N/A
  • Approval: Have discussed with and got approval from the team1
  • Tests: Tested accessibility on the local end
  • Deployment: Deployed the app on the local end
  • Localization: Modified en-US string resources2
  • Co-authors: N/A

Steps To Validate Changes

N/A

Screenshots

Before
image

After
image

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do, instead.

@0x5bfa
Copy link
Member Author

0x5bfa commented Oct 22, 2023

@yaira2 Ready for review.

Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that LGTM

src/Files.App/Data/Items/DriveItem.cs Outdated Show resolved Hide resolved
@yaira2 yaira2 changed the title Fix: Added the tooltip for the eject button Fix: Added tooltip to the eject button Oct 24, 2023
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Oct 24, 2023
yaira2
yaira2 previously approved these changes Oct 25, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Oct 25, 2023
@yaira2 yaira2 merged commit d8eb476 into files-community:main Oct 25, 2023
1 check was pending
@0x5bfa 0x5bfa deleted the 5bfa/Add-EjectTooltipOnSideBar branch October 31, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants