Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Disabled keyboard shortcuts when renaming items #13118

Merged

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Aug 1, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Disable keyboard shortcuts when renaming items #12053

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Start renaming an item
    2. Try to use any shortcut (you should consider changing some shortcuts to Shift + Letter to test deeper)

@yaira2
Copy link
Member

yaira2 commented Aug 1, 2023

Do the TextBox shortcuts work (eg, ctrl + c, ctrl + v, ctrl + a)?

@yaira2
Copy link
Member

yaira2 commented Aug 1, 2023

There are also some shortcuts for switching which file is being renamed (tab and shift + tab)

@yaira2 yaira2 self-requested a review August 1, 2023 23:05
@yaira2 yaira2 changed the title Feature: Disable keyboard shortcuts when renaming items Feature: Disabled keyboard shortcuts when renaming items Aug 1, 2023
@ferrariofilippo
Copy link
Contributor Author

Do the TextBox shortcuts work (eg, ctrl + c, ctrl + v, ctrl + a)?
There are also some shortcuts for switching which file is being renamed (tab and shift + tab)

They still work

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 789cb1d into files-community:main Aug 2, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 2, 2023
@ferrariofilippo ferrariofilippo deleted the Disable_Shortcuts_When_Renaming branch August 2, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Disable keyboard shortcuts when renaming items
2 participants