Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Disable keyboard shortcuts when renaming items #12053

Closed
ferrariofilippo opened this issue Apr 12, 2023 · 1 comment · Fixed by #13118
Closed

Feature: Disable keyboard shortcuts when renaming items #12053

ferrariofilippo opened this issue Apr 12, 2023 · 1 comment · Fixed by #13118

Comments

@ferrariofilippo
Copy link
Contributor

What feature or improvement do you think would benefit Files?

I think that keyboard shortcuts that are not related with editing should be disabled when renaming items.
We should still handle other common shortcuts such as Esc, Ctrl + A, ...

Requirements

  • This feature will prevent future issues involving RichCommands remapping (think of a user assigning a shortcut to Shift + Letter)

Files Version

2.4.61.0

Windows Version

Windows 11 Pro 22H2 10.0.22621.1485

Comments

No response

@yaira2
Copy link
Member

yaira2 commented Apr 14, 2023

We have a lot of checks in place, but it's a good idea to simplify the code and disable them altogether.

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Apr 14, 2023
@Josh65-2201 Josh65-2201 removed the status in Files task board Aug 2, 2023
@Josh65-2201 Josh65-2201 moved this to 🏗 In progress in Files task board Aug 2, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants