Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed freeze when right-clicking immediately after launching the app #13094

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    If you right-click immediately after launching the app, you may notice that the "New" submenu lacks some item, but anyway no crash happens.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 28, 2023
@yaira2 yaira2 merged commit fe1a4ec into files-community:main Jul 28, 2023
@yaira2 yaira2 changed the title Fix: Fixed freeze that occurred when right-clicking immediately after launching the app Fix: Fixed freeze when right-clicking immediately after launching the app Jul 28, 2023
@hishitetsu hishitetsu deleted the FixRightClickFreeze branch July 28, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Right clicking folder when it's still loading causes app to crash
2 participants