Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where open in VS Code didn't work if there were spaces in the path #12667

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Added open in VS/VS Code to status bar #12645

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Navigate to a git repository that has a " " in the path
    2. Use "Open in VS" or "Open in VS Code" button

@yaira2 yaira2 changed the title Fix: Fixed a bug with Open in VS & VS Code Fix: Fixed issue where open in VS Code didn't work if there were spaces in the path Jun 20, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 20, 2023
@yaira2 yaira2 merged commit ae5c327 into files-community:main Jun 20, 2023
@ferrariofilippo ferrariofilippo deleted the Fix_Open_In_VS branch June 21, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants