Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added open in VS/VS Code to status bar #12645

Merged
merged 17 commits into from
Jun 19, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add open in vs code/studio button to the status bar #12632

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app and navigate to a directory containing a .sln file
    2. Click on Open in VS
    3. Navigate to a git directory
    4. Click on Open in VS Code

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea! Some suggestions here.

src/Files.App/UserControls/StatusBarControl.xaml Outdated Show resolved Hide resolved
src/Files.App/Data/Models/ItemViewModel.cs Outdated Show resolved Hide resolved
src/Files.App/Data/Models/ItemViewModel.cs Show resolved Hide resolved
src/Files.App/Actions/Open/OpenInVSCodeAction.cs Outdated Show resolved Hide resolved
src/Files.App/Actions/Open/OpenInVSAction.cs Outdated Show resolved Hide resolved
src/Files.App/Actions/Open/OpenInVSAction.cs Outdated Show resolved Hide resolved
src/Files.App/Actions/Open/OpenInVSCodeAction.cs Outdated Show resolved Hide resolved
@yaira2 yaira2 changed the title Feature: Open in VS/VS Code buttons Feature: Added open in VS/VS Code to status bar Jun 19, 2023
@yaira2 yaira2 requested a review from 0x5bfa June 19, 2023 12:38
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 19, 2023
@yaira2 yaira2 merged commit a44bc19 into files-community:main Jun 19, 2023
@ferrariofilippo ferrariofilippo deleted the Feature_Open_Button branch June 19, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add open in vs code/studio button to the status bar
3 participants