Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where credentials dialog wasn't shown when accessing FTP #12329

Merged
merged 2 commits into from
May 11, 2023
Merged

Fix: Fixed issue where credentials dialog wasn't shown when accessing FTP #12329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56cdbbd
Fix: Credentials dialog isn't shown when accessing FTP
ferrariofilippo May 11, 2023
3426369
Merge branch 'main' into Fix_Ftp_Connection
yaira2 May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Files.App/ViewModels/ItemViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,15 +1442,15 @@ public async Task EnumerateItemsFromSpecialFolderAsync(string path)
client.Port = FtpHelpers.GetFtpPort(path);
client.Credentials = FtpManager.Credentials.Get(client.Host, FtpManager.Anonymous);

static Task<FtpProfile?> WrappedAutoConnectFtpAsync(AsyncFtpClient client)
static async Task<FtpProfile?> WrappedAutoConnectFtpAsync(AsyncFtpClient client)
{
try
{
return client.AutoConnect();
return await client.AutoConnect();
}
catch (FtpAuthenticationException)
{
return Task.FromResult<FtpProfile?>(null);
return null;
}

throw new InvalidOperationException();
Expand Down