Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where credentials dialog wasn't shown when accessing FTP #12329

Merged
merged 2 commits into from
May 11, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Refactor: Continued work on reducing async state machines #12010

Notes
Removing async from that method would prevent the exception from being caught by the local catch

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Try to access an ftp folder
    3. See that the Credentials dialog is shown

@yaira2 yaira2 changed the title Fix: Credentials dialog isn't shown when accessing FTP Fix: Fixed issue where credentials dialog wasn;t shown when accessing FTP May 11, 2023
@yaira2 yaira2 requested a review from 0x5bfa May 11, 2023 14:15
@0x5bfa
Copy link
Member

0x5bfa commented May 11, 2023

I dont have FTP server.

@yaira2 yaira2 changed the title Fix: Fixed issue where credentials dialog wasn;t shown when accessing FTP Fix: Fixed issue where credentials dialog wasn't shown when accessing FTP May 11, 2023
@yaira2
Copy link
Member

yaira2 commented May 11, 2023

Everything looks good, I just wanted to check if you had the permissions to approve this PR.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 11, 2023
@yaira2 yaira2 merged commit aae3dfe into files-community:main May 11, 2023
@ferrariofilippo ferrariofilippo deleted the Fix_Ftp_Connection branch May 11, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants