Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Removed tooltip from details layout #11962

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Feature: Removed tooltip from details layout #11962

merged 1 commit into from
Apr 4, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Apr 4, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Discussion: Add a setting to disable tooltips #11195

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Hover over an item in the details layout and verify that the tooltip doesn't show

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 4, 2023
@hishitetsu
Copy link
Member

hishitetsu commented Apr 4, 2023

Should this be done? The tooltip is visible in the detailed layout of File Explorer.
I certainly don't think it makes much sense.

@yaira2
Copy link
Member Author

yaira2 commented Apr 4, 2023

The general feedback is that the tooltip doesn't provide any value in the details layout.

@yaira2 yaira2 merged commit 5d67015 into main Apr 4, 2023
@yaira2 yaira2 deleted the ya/Tooltip branch April 4, 2023 02:46
@hishitetsu
Copy link
Member

Sorry, I see that this was already discussed.
Certainly this does not seem to need to be the same as File Explorer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: Add a setting to disable tooltips
2 participants