Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Inject view models #11820

Merged
merged 10 commits into from
Mar 26, 2023
Merged

Feature: Inject view models #11820

merged 10 commits into from
Mar 26, 2023

Conversation

lukeblevins
Copy link
Contributor

@lukeblevins lukeblevins commented Mar 23, 2023

#4180
Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
N/A

@lukeblevins
Copy link
Contributor Author

also looping in: @d2dyno1

@yaira2
Copy link
Member

yaira2 commented Mar 23, 2023

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@lukeblevins lukeblevins marked this pull request as ready for review March 24, 2023 13:04
@yaira2 yaira2 changed the title feat: Inject view models Feature: Inject view models Mar 24, 2023
@yaira2 yaira2 requested a review from d2dyno1 March 24, 2023 14:04
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Mar 24, 2023
@lukeblevins lukeblevins requested review from yaira2 and removed request for d2dyno1 March 24, 2023 14:16
@lukeblevins lukeblevins requested a review from yaira2 March 24, 2023 15:29
@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Mar 24, 2023
yaira2
yaira2 previously approved these changes Mar 24, 2023
@yaira2 yaira2 requested a review from d2dyno1 March 24, 2023 16:53
@lukeblevins lukeblevins requested review from hecksmosis and removed request for d2dyno1 March 24, 2023 19:23
@hecksmosis
Copy link
Contributor

Apart from that LGTM

src/Files.App/Helpers/JumpListHelper.cs Outdated Show resolved Hide resolved
src/Files.App/ServicesImplementation/JumpListService.cs Outdated Show resolved Hide resolved
src/Files.App/ServicesImplementation/JumpListService.cs Outdated Show resolved Hide resolved
src/Files.Shared/Services/IJumpListService.cs Outdated Show resolved Hide resolved
@ferrariofilippo
Copy link
Contributor

Can you consider adding SidebarViewModel.cs to services? It is istantiated only once in the whole application (in MainPage.xaml.cs

@yaira2
Copy link
Member

yaira2 commented Mar 24, 2023

Can you consider adding SidebarViewModel.cs to services? It is istantiated only once in the whole application (in MainPage.xaml.cs

We're going to limit the scope of this PR to what's already implemented and merge it once the requested changes are complete.

@lukeblevins lukeblevins requested review from d2dyno1, yaira2 and hecksmosis and removed request for d2dyno1, yaira2 and hecksmosis March 26, 2023 02:31
@yaira2 yaira2 requested a review from hecksmosis March 26, 2023 02:52
@yaira2 yaira2 merged commit 8288b09 into files-community:main Mar 26, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 26, 2023

@lukeblevins thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants