Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Default color schemes have very little impact in the color scheme #11989

Closed
rafaskb opened this issue Apr 5, 2023 · 6 comments · Fixed by #12036
Closed

Bug: Default color schemes have very little impact in the color scheme #11989

rafaskb opened this issue Apr 5, 2023 · 6 comments · Fixed by #12036

Comments

@rafaskb
Copy link

rafaskb commented Apr 5, 2023

Description

When applying one of the predefined color schemes to Files on version, it seems like the impact they have on changing Files colors is very little. The same color schemes were much more noticeable on 2.4.40.0.

Assigning a custom color works as expected.

Steps To Reproduce

  1. Go to Settings
  2. Go to Appearances
  3. Select one of the predefined color schemes, such as "Red"
  4. Files should be Red now, but it isn't

Requirements

  • Use the correct color when choosing one of the built-in options

Files Version

2.4.61.0

Windows Version

10.0.19044.2728

Log file

bandicam_2023-04-05_17-56-29-430.mp4
@rafaskb rafaskb added the bug label Apr 5, 2023
@yaira2 yaira2 changed the title Default color schemes have very little impact in the color scheme after 2.4.60.0 Bug: Default color schemes have very little impact in the color scheme Apr 5, 2023
@yaira2 yaira2 moved this to 🔖 Ready to build in Files task board Apr 5, 2023
@Jimmy20220531
Copy link

my video,哈哈。

@ferrariofilippo
Copy link
Contributor

At the moment, the A is set to 0x32 I think we should change that to something like 0x60. Should they have even more impact?
@0x5bfa I'd like to hear your opinion on this

Light B/A (Red):
Before_Light
After_Light

Dark B/A (Red):
Before_Dark
After_dark

@rafaskb
Copy link
Author

rafaskb commented Apr 7, 2023

Personally I would push it even farther, 0xB0 or even 0xC0 perhaps.
I see the default color schemes as something that says "Hey do you want to radically change the appearance of the app? Here are some choices!", while the fine tuning in the config files say "But if you want to fine tune it to your liking, here are the configs"

@ferrariofilippo
Copy link
Contributor

Personally I would push it even farther, 0xB0 or even 0xC0 perhaps. I see the default color schemes as something that says "Hey do you want to radically change the appearance of the app? Here are some choices!", while the fine tuning in the config files say "But if you want to fine tune it to your liking, here are the configs"

I agree with you on the radically change thing (I use 0xFF, which I think most people would consider awful).
Still, I'm not sure how much the average user would like this "hard" change

@0x5bfa
Copy link
Member

0x5bfa commented Apr 8, 2023

As it's a difficult issue, I cannot say It must be or should be sth, however I'd say that pushing it further is agreeable and like to be set to 0xA0. In opacity setting, would like to be set to 0.7

@yaira2
Copy link
Member

yaira2 commented Apr 10, 2023

I confirmed that this was introduced in #11820

@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants