Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fix duplicate window opening when pressing Ctrl+N #10648

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Fix: Fix duplicate window opening when pressing Ctrl+N #10648

merged 4 commits into from
Dec 7, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 7, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

  1. Made "open new window" and "open new tab" async relay commands to fix them being fired multiple times
  2. Moved "file in use" check from Logger.cs to UniversalLogWriter.cs so it's used also when initializing the logger.

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 changed the title Issue ctrl n Fix: Fix duplicate window opening when pressing Ctrl+N Dec 7, 2022
yaira2
yaira2 previously approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 7, 2022
@yaira2 yaira2 merged commit 41556c8 into files-community:main Dec 7, 2022
@gave92 gave92 deleted the issue_ctrl_n branch December 8, 2022 04:09
@QuaintMako QuaintMako mentioned this pull request Dec 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: CTRL+N throws error
2 participants
@gave92 @yaira2