Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: App crashes when opening a lot of tabs #2145

Closed
R3voA3 opened this issue Oct 25, 2020 · 13 comments
Closed

Bug: App crashes when opening a lot of tabs #2145

R3voA3 opened this issue Oct 25, 2020 · 13 comments
Labels
good first issue Good issue for new contributors to get started with

Comments

@R3voA3
Copy link
Contributor

R3voA3 commented Oct 25, 2020 •
edited by yaira2
Loading

Steps to reproduce

  • Open many tabs very quickly by holding CTRL + T.

Requirements
Fix crash when opening many tabs

debug_fulltrust.txt
debug.txt
@R3voA3 R3voA3 added the bug label Oct 25, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@yaira2 yaira2 mentioned this issue Jan 5, 2021
Closed
@yaira2 yaira2 changed the title App crashes when too many tabs are opened quickly. App crashes when more than 10 tabs are open at a time Jan 5, 2021
@yaira2
Copy link
Member

yaira2 commented Mar 21, 2021

This issue appears to be resolved in main.

@yaira2 yaira2 closed this as completed Mar 21, 2021
@lukeblevins lukeblevins reopened this Mar 21, 2021
@lukeblevins
Copy link
Contributor

Reopening to track potential regressions here after #4209

@yaira2 yaira2 closed this as completed Mar 31, 2021
@yaira2 yaira2 added fixed and removed critical labels Mar 31, 2021
@yaira2 yaira2 reopened this Mar 31, 2021
@yaira2 yaira2 changed the title App crashes when more than 10 tabs are open at a time App crashes when opening a lot of tabs Mar 31, 2021
@yaira2 yaira2 added the good first issue Good issue for new contributors to get started with label May 11, 2022
@yaira2 yaira2 moved this to 🆕 New in Files task board Sep 8, 2022
@Josh65-2201
Copy link
Member

Is this still an issue in 2.3.11.0 or above?

@Josh65-2201 Josh65-2201 added the needs - additional info Needs more information from the reporter label Sep 9, 2022
@yaira2
Copy link
Member

yaira2 commented Sep 9, 2022

Yes

@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label Oct 2, 2022
@yaira2 yaira2 changed the title App crashes when opening a lot of tabs Bug: App crashes when opening a lot of tabs Oct 20, 2022
@yaira2 yaira2 moved this from 🆕 New to 📋 Planning stage in Files task board Oct 20, 2022
@yaira2 yaira2 moved this from 📋 Planning stage to 🔖 Ready to build in Files task board Oct 20, 2022
@QuaintMako
Copy link
Contributor

The crash seems to only happen when using the keyboard accelerator. Tried to open 40 tabs at the same time using another path of call. Reducing the accelerator to "one press = one use" should do the trick.

@QuaintMako QuaintMako mentioned this issue Oct 28, 2022
Closed
@yaira2
Copy link
Member

yaira2 commented Oct 28, 2022

Seems like a reasonable solution, I think we do something similar with the back/forward buttons.

@QuaintMako
Copy link
Contributor

Are you talking about those accelerators?

image

@yaira2
Copy link
Member

yaira2 commented Oct 28, 2022

It might have actually been the refresh button but similar idea.

@QuaintMako QuaintMako mentioned this issue Nov 2, 2022
Closed
1 task
@QuaintMako
Copy link
Contributor

@gave92 the work done in #10648 doesn't seem to fix that issue for me. Is there some work left to do on the basis of it?

@gave92
Copy link
Member

gave92 commented Dec 10, 2022 •
edited
Loading

Could be, as I could never reproduce the issue in the first place.
But I expected #10648 to have the same effect as #10385 (wait until a tab has been opened before adding the next tab).
Does #10385 fix the issue if applied on current main?

@QuaintMako
Copy link
Contributor

#10385 does not seem to solve the crash entirely anymore. If anything, it makes the issue a lot less worse.

Instead of crashing after 1 tab on main when holding the shortcut, it crashes after ~70 tabs for me. Better, but still not a fix.

I'm closing #10385 to investigate a better solution.

@QuaintMako QuaintMako mentioned this issue Dec 13, 2022
Closed
2 tasks
@yaira2 yaira2 mentioned this issue Feb 1, 2023
Closed
@yaira2
Copy link
Member

yaira2 commented Mar 16, 2023

@QuaintMako I opened an issue to track your idea for solving this #11737.

@yaira2 yaira2 closed this as completed Mar 16, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for new contributors to get started with
Projects
Files task board
Archived in project
Milestone
No milestone
6 participants
@gave92 @R3voA3 @lukeblevins @Josh65-2201 @yaira2 @QuaintMako