Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain Sidebar state #6469

Closed
TDMatthews opened this issue Oct 12, 2021 · 7 comments · Fixed by #9004
Closed

Maintain Sidebar state #6469

TDMatthews opened this issue Oct 12, 2021 · 7 comments · Fixed by #9004

Comments

@TDMatthews
Copy link

Description

Settings allow for sections in the sidebar to be toggled on and off. It is desirable to maintain tsidebar stat (expanded / collapsed) between sessions. Currently closing the application when maximized does not maintain current state and all panels open minimized.

Steps To Reproduce

  • Set a default folder and set 'show drives section' to true.
  • Expand drives
  • maximize window and close app
  • relauch app and drive section is collapsed

Expected behavior

expanded / collapsed state should be maintained regardless of window state

Files Version

2.0.13.0

Windows Version

Windows 11

Relevant Assets

No response

@TDMatthews TDMatthews added the bug label Oct 12, 2021
@wonrax
Copy link

wonrax commented Nov 9, 2021

I think Files is remembering the sidebar state, but it's not expanding it correctly when you open a new session. The proof is you have to click twice to make the item expand (gif).

Steps to reproduce:

  • Expand Favorites (or anything expandable) in the sidebar
  • Close and reopen Files
  • The current state of Favorites is expanded, but not visually expanded
  • Have to click twice to visually expand the item (the first click is to collapse, and the second click eventually expands the item)

Version: 2.0.34.0
OS Version: 10.0.22000.282

@d2dyno1
Copy link
Member

d2dyno1 commented Nov 12, 2021

Related #4128

@yaira2
Copy link
Member

yaira2 commented Nov 12, 2021

@d2dyno1 isn't this a duplicate of #4128?

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Nov 12, 2021
@d2dyno1
Copy link
Member

d2dyno1 commented Nov 12, 2021

@d2dyno1 isn't this a duplicate of #4128?

@yaichenbaum Nope, this issue is about sections not being extended after reopening the app.

@Korkman
Copy link

Korkman commented Jan 23, 2022

grafik
grafik

Definitely some race happening. Note the arrow directions. Up should be expanded, down should be closed. Only when I expand or collapse all items it works as expected.

@hanskokx
Copy link

Animation

@yaira2 yaira2 added the fixed label Apr 26, 2022
@yaira2
Copy link
Member

yaira2 commented Apr 26, 2022

This issue should be resolved with #9004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants