Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci improve clippy (rebased) #1465

Merged
merged 13 commits into from
Jun 7, 2021
Merged

Ci improve clippy (rebased) #1465

merged 13 commits into from
Jun 7, 2021

Commits on Jun 2, 2021

  1. chore: improve Clippy on CI 

    Clippy is run on CI, but even if there are warnings, the CI doesn't
fail. With this commit the CI fails when there are Clippy warnings.
It also runs Clippy on all the code (also tests, benchmarks and
examples) now.
    @vmx @cryptonemo
    vmx authored and cryptonemo committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    fd2c25b View commit details
    Browse the repository at this point in the history

  2. feat: re-factor benches to make clippy happy 

    feat: clean-up some clippy warnings
    @cryptonemo
    cryptonemo committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    ba9f8a8 View commit details
    Browse the repository at this point in the history

  3. feat: more clippy cleanups

    @cryptonemo
    cryptonemo committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    b6cb75e View commit details
    Browse the repository at this point in the history

  4. style: rust fmt

    @cryptonemo
    cryptonemo committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    135756c View commit details
    Browse the repository at this point in the history

  5. feat: more clippy updates, but broken atm

    @cryptonemo
    cryptonemo committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    6ed54c3 View commit details
    Browse the repository at this point in the history

  6. fix: final clippy cleanups

    @cryptonemo
    cryptonemo committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    0b49e54 View commit details
    Browse the repository at this point in the history

  7. style: rust fmt

    @cryptonemo
    cryptonemo committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    f2e3448 View commit details
    Browse the repository at this point in the history

  8. fix: uniquely name benches (required)

    @cryptonemo
    cryptonemo committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    317d944 View commit details
    Browse the repository at this point in the history

  9. feat: clippy updates required after rebase on master

    @cryptonemo
    cryptonemo committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    e5ad10b View commit details
    Browse the repository at this point in the history

  10. refactor: create PathBuf directly 

    Create a PathBuf for more symmetry within the if/else clause.
    @vmx @cryptonemo
    vmx authored and cryptonemo committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    ac56ece View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. refactor: change back to using a PathBuf 

    Instead using a string first, change code back to use a `PathBuf` directly.
    @vmx @cryptonemo
    vmx authored and cryptonemo committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    4312b13 View commit details
    Browse the repository at this point in the history

  2. refactor: rename variable for clarity

    @vmx @cryptonemo
    vmx authored and cryptonemo committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    7fb2b7f View commit details
    Browse the repository at this point in the history

  3. style: add clippy allows to avoid interface change

    @cryptonemo
    cryptonemo committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    03a69d4 View commit details
    Browse the repository at this point in the history