Ci improve clippy (rebased) #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy is run on CI, but even if there are warnings, the CI doesn't fail. With this commit the CI fails when there are Clippy warnings. It also runs Clippy on all the code (also tests, benchmarks and examples) now.
feat: clean-up some clippy warnings
Create a PathBuf for more symmetry within the if/else clause.
Closed
vmx
previously approved these changes
Jun 4, 2021
| @@ -113,30 +113,38 @@ fn test_verify_simple_pieces() { | |||
| // / \ / \ | |||
| // a b c d | |||
|
|
|||
| let (a, b, c, d): ([u8; 32], [u8; 32], [u8; 32], [u8; 32]) = rng.gen(); | |||
There was a problem hiding this comment.
I am okay with this, but in general we should just put a clippy allow on this function
dignifiedquire
previously approved these changes
Jun 4, 2021
Instead using a string first, change code back to use a `PathBuf` directly.
cryptonemo
force-pushed
the
ci-improve-clippy-rebased
branch
from
534eac6
to
03a69d4
Compare
dignifiedquire
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to replace #1461 and #1464