Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement external iteration for the AMT #1861

Closed
Stebalien opened this issue Aug 30, 2023 · 3 comments
Closed

Implement external iteration for the AMT #1861

Stebalien opened this issue Aug 30, 2023 · 3 comments
Assignees
@jdjaustin
Labels
good first issue Good for newcomers Kind: Improvement An improvement of something that exists. P3 P3: Might get resolved

Comments

@Stebalien
Copy link
Member

I.e., implement a rust Iterator for the AMT and re-implement the for_each implementation in terms of this new iterator.

See #286.
@Stebalien Stebalien added Kind: Improvement An improvement of something that exists. good first issue Good for newcomers P3 P3: Might get resolved labels Aug 30, 2023
@jdjaustin jdjaustin self-assigned this Aug 31, 2023
@jdjaustin jdjaustin mentioned this issue Oct 18, 2023
Merged
Stebalien pushed a commit that referenced this issue Nov 29, 2023
@jdjaustin
Implement external iteration for the AMT (#1912)
473374a 
Implement a Rust Iterator for the AMT and re-implement the for_each implementation in terms of this new iterator. Also improve documentation. Closes issue #1861.
@Stebalien
Copy link
Member Author

The remaining part here is to implement iter_from, iterating from an offset.

@arajasek arajasek mentioned this issue Dec 5, 2023
Closed
Stebalien added a commit that referenced this issue Jan 22, 2024
@Stebalien
feat: amt: implement external iteration for ranged iteration
1737133 
part of #1861
@Stebalien
Copy link
Member Author

Ok, we also need iter_mut.

@Stebalien Stebalien mentioned this issue Jan 22, 2024
Merged
Stebalien added a commit that referenced this issue Jan 25, 2024
@Stebalien @rvagg
Implement external iteration for AMT range iteration (#1965)
daefd6b 
part of #1861

Co-authored-by: Rod Vagg <[email protected]>
@Stebalien
Copy link
Member Author

Replaced with #1996.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdjaustin jdjaustin

Labels
good first issue Good for newcomers Kind: Improvement An improvement of something that exists. P3 P3: Might get resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @jdjaustin