Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace for_each_mut (internal iteration) with iter_mut (external iteration) in the AMT #1996

Open
Stebalien opened this issue Feb 20, 2024 · 8 comments
Labels
good first issue Good for newcomers Kind: Improvement An improvement of something that exists.

Comments

@Stebalien
Copy link
Member

The iterator will have to yield a smart pointer that:

  1. Can be dereferenced immutably with no affect.
  2. Can be dereferenced mutably, marking the value as changed.
  3. Can be deleted (e.g., by calling some form of ptr.delete() method). This method should consume the smart pointer (possibly returning the inner value).

This will get rid of the last "internal" iteration feature.

@Stebalien Stebalien added Kind: Improvement An improvement of something that exists. good first issue Good for newcomers labels Feb 20, 2024
@PhantomOz
Copy link

can i work on this?

@Stebalien
Copy link
Member Author

Absolutely! Take a look at how we currently use it here.

@rjan90
Copy link
Contributor

rjan90 commented Aug 21, 2024

Hey @PhantomOz! Are you still interested in working on this, or should I unassign you?

@rjan90
Copy link
Contributor

rjan90 commented Sep 4, 2024

Unassigning since I have not hear back yet.

@PhantomOz
Copy link

I apologize didn't notice that i was assigned till now, Please reassign so that I can work on it @rjan90

@rjan90
Copy link
Contributor

rjan90 commented Sep 5, 2024

No worries! Reassigned to you now 👍

@rjan90
Copy link
Contributor

rjan90 commented Sep 24, 2024

Hey @PhantomOz! Do you need some additional guidance on this issue ticket? How is the progress on going on this?

@PhantomOz
Copy link

@rjan90 Yes I do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Kind: Improvement An improvement of something that exists.
Projects
Status: 🐱 Todo
Development

No branches or pull requests

3 participants