Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move eth functions out of api #9872

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Closes #9825

Leaving bigger changes from #9870 to another day.

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner December 14, 2022 16:58
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 suggestions:

  • move the new types to a new chain/types/eth/ directory?
  • can EthTxReceipt stay in api? I don't think we need to move it.

I'm not thrilled about the JSON marshaling stuff moving into chain/types, but the alternative is to have type aliases in the API module that we define the JSON logic on. I don't think we need to do that now (but would like it to happen someday -- maybe open an issue for it?)

@arajasek arajasek merged commit 0c305ed into feat/nv18-fevm Dec 14, 2022
@arajasek arajasek deleted the gstuart/dont-depend-on-api-refactor-minimal branch December 14, 2022 22:06
@jennijuju jennijuju added this to the Network v18 milestone Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants