Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Move "core" Eth types from api to types #9825

Closed
arajasek opened this issue Dec 9, 2022 · 1 comment
Closed

Refactor: Move "core" Eth types from api to types #9825

arajasek opened this issue Dec 9, 2022 · 1 comment
Labels
kind/refactor P1 P1: Must be resolved
Milestone
Network v18

Comments

@arajasek
Copy link
Contributor

arajasek commented Dec 9, 2022

It's inappropriate for the consensus components in Lotus to be depending on the API. With filecoin-project/ref-fvm#1204, things like EthTxArgs become part of the Filecoin protocol, and so should move to chain/types.
@arajasek arajasek added this to the Network v18 milestone Dec 9, 2022
@jennijuju jennijuju added P1 P1: Must be resolved P2 P2: Should be resolved and removed P1 P1: Must be resolved labels Dec 9, 2022
@arajasek
Copy link
Contributor Author

We should add a ToDigest method on Ethereum Txs for siggy validation too.

@arajasek arajasek reopened this Dec 11, 2022
@jennijuju jennijuju added P1 P1: Must be resolved and removed P2 P2: Should be resolved labels Dec 11, 2022
This was referenced Dec 14, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/refactor P1 P1: Must be resolved
Projects
No open projects
Network v18
Status: ✅ Done
Milestone
Network v18
3 participants
@arajasek @geoff-vball @jennijuju