Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli: set current network version from params #8120

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

travisperson
Copy link
Contributor

allows automation to correctly set the network version for the currently built network with no variable inputs.

Related Issues

When creating a network, by default, the latest network version (NewestNetworkVersion) is used in the genesis network template file. If the network does not start on the default latest network version (eg has upgrade epochs set / GenesisNetworkVersion is smaller), the network will fail to startup due to invalid network versions.

Proposed Changes

Add a flag that will use the build param GenesisNetworkVersion to set the network version. This ensures that the genesis network version always matches the network being built (if lotus-seed is built with the network flags).

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

allows automation to correctly set the network version for the currently
built network with no variable inputs.
@travisperson travisperson requested a review from a team as a code owner February 17, 2022 00:07
@arajasek arajasek merged commit 4767f3d into feat/fvm Feb 17, 2022
@arajasek arajasek deleted the travis/set-current-network-version branch February 17, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants