feat: cli: set current network version from params #8111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows automation to correctly set the network version for the currently built network with no variable inputs.
Related Issues
When creating a network, by default, the latest network version (
NewestNetworkVersion
) is used in the genesis network template file. If the network does not start on the default latest network version (eg has upgrade epochs set /GenesisNetworkVersion
is smaller), the network will fail to startup due to invalid network versions.Proposed Changes
Add a flag that will use the build param
GenesisNetworkVersion
to set the network version. This ensures that the genesis network version always matches the network being built (if lotus-seed is built with the network flags).Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps