Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore nil throttler #7169

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Ignore nil throttler #7169

merged 1 commit into from
Aug 24, 2021

Conversation

aarshkshah1992
Copy link
Contributor

Closes #7048 .

@aarshkshah1992 aarshkshah1992 requested a review from a team as a code owner August 24, 2021 05:12
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #7169 (e1a056d) into master (01ea39a) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7169      +/-   ##
==========================================
+ Coverage   34.78%   34.82%   +0.03%     
==========================================
  Files         684      684              
  Lines       80040    80041       +1     
==========================================
+ Hits        27845    27873      +28     
+ Misses      46522    46509      -13     
+ Partials     5673     5659      -14     
Impacted Files Coverage Δ
node/impl/storminer.go 23.90% <0.00%> (+1.34%) ⬆️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
extern/sector-storage/worker_tracked.go 90.14% <0.00%> (-4.23%) ⬇️
storage/wdpost_sched.go 77.22% <0.00%> (-1.99%) ⬇️
extern/sector-storage/sched_worker.go 77.25% <0.00%> (-0.73%) ⬇️
chain/messagepool/selection.go 80.52% <0.00%> (-0.41%) ⬇️
extern/storage-sealing/fsm.go 57.83% <0.00%> (-0.41%) ⬇️
chain/messagepool/messagepool.go 57.17% <0.00%> (-0.38%) ⬇️
extern/sector-storage/stores/local.go 59.25% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ea39a...e1a056d. Read the comment docs.

@aarshkshah1992 aarshkshah1992 merged commit 5993257 into master Aug 24, 2021
@aarshkshah1992 aarshkshah1992 deleted the feat/dagstore-zero-concurrency branch August 24, 2021 07:50
return
if throttle != nil {
select {
case <-throttle:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a send to the throttle channel that will block below if the channel is nil.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dagstore Initialize Command Hangs With Zero Concurrency
3 participants