Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dagstore/InitializeAll: Fix throttling bug for concurrency=0 #7177

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

aarshkshah1992
Copy link
Contributor

Address #7169 (comment).

@aarshkshah1992 aarshkshah1992 requested a review from a team as a code owner August 25, 2021 10:49
@aarshkshah1992 aarshkshah1992 requested a review from raulk August 25, 2021 10:49
@aarshkshah1992 aarshkshah1992 requested a review from dirkmc August 25, 2021 10:51
@aarshkshah1992 aarshkshah1992 changed the title Fix throttling bug dagstore/InitializeAll: Fix throttling bug Aug 25, 2021
@aarshkshah1992 aarshkshah1992 changed the title dagstore/InitializeAll: Fix throttling bug dagstore/InitializeAll: Fix throttling bug for concurrency=0 Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #7177 (928ac21) into master (87fc8db) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7177      +/-   ##
==========================================
- Coverage   34.85%   34.82%   -0.03%     
==========================================
  Files         685      685              
  Lines       80187    80188       +1     
==========================================
- Hits        27947    27927      -20     
- Misses      46553    46566      +13     
- Partials     5687     5695       +8     
Impacted Files Coverage Δ
node/impl/storminer.go 22.46% <0.00%> (-0.05%) ⬇️
journal/types.go 86.66% <0.00%> (-13.34%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
node/hello/hello.go 63.21% <0.00%> (-3.45%) ⬇️
journal/fs.go 68.25% <0.00%> (-3.18%) ⬇️
extern/storage-sealing/fsm.go 55.42% <0.00%> (-1.21%) ⬇️
chain/store/store.go 63.41% <0.00%> (-1.07%) ⬇️
chain/stmgr/execute.go 74.09% <0.00%> (-1.04%) ⬇️
chain/sync_manager.go 66.77% <0.00%> (-0.63%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fc8db...928ac21. Read the comment docs.

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better. We need tests for these operations! #7138

@aarshkshah1992 aarshkshah1992 merged commit 7739051 into master Aug 25, 2021
@aarshkshah1992 aarshkshah1992 deleted the feat/fix-send-nil-throttle branch August 25, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants