feat: FVM: do not error on unsuccessful implicit messages #11120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
approved these changes
Jul 31, 2023
chain/consensus/compute_state.go
Outdated
| @@ -135,6 +135,10 @@ func (t *TipSetExecutor) ApplyBlocks(ctx context.Context, | |||
| return xerrors.Errorf("running cron: %w", err) | |||
| } | |||
|
|
|||
| if !ret.ExitCode.IsSuccess() { | |||
| return xerrors.Errorf("cron failed with exit code %d: %s", ret.ExitCode, ret.ActorErr.Error()) | |||
There was a problem hiding this comment.
nit for here and reward error handling: to maintain existing behavior you could end err string with %w and wrap the error instead of printing as string
arajasek
force-pushed
the
asr/shut-up-disputer
branch
from
a76224b
to
cd958e4
Compare
7 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#11061
The FVM currently errors on unsuccessful
Implicitmessages -- that is, a failure exit code is treated as an error. This essentially assumes that all callers ofApplyImplicitMessagewants to treat a non-zero code as an error. While this is generally true, some callers (eg. when simulating messages) might not want to handle non-zero exit codes as errors.Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps