feat: FVM: do not error on unsuccessful implicit messages

filecoin-project · Jul 31, 2023 · a76224b · a76224b
1 parent 3f93b86
commit a76224b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/chain/consensus/compute_state.go b/chain/consensus/compute_state.go
@@ -135,6 +135,10 @@ func (t *TipSetExecutor) ApplyBlocks(ctx context.Context,
 			return xerrors.Errorf("running cron: %w", err)
 		}
 
+		if !ret.ExitCode.IsSuccess() {
+			return xerrors.Errorf("cron failed with exit code %d: %s", ret.ExitCode, ret.ActorErr.Error())
+		}
+
 		cronGas += ret.GasUsed
 
 		if em != nil {

diff --git a/chain/consensus/filcns/filecoin.go b/chain/consensus/filcns/filecoin.go
@@ -80,6 +80,11 @@ var RewardFunc = func(ctx context.Context, vmi vm.Interface, em stmgr.ExecMonito
 	if actErr != nil {
 		return xerrors.Errorf("failed to apply reward message: %w", actErr)
 	}
+
+	if !ret.ExitCode.IsSuccess() {
+		return xerrors.Errorf("reward actor failed with exit code %d: %s", ret.ExitCode, ret.ActorErr.Error())
+	}
+
 	if em != nil {
 		if err := em.MessageApplied(ctx, ts, rwMsg.Cid(), rwMsg, ret, true); err != nil {
 			return xerrors.Errorf("callback failed on reward message: %w", err)

diff --git a/chain/vm/fvm.go b/chain/vm/fvm.go
@@ -520,10 +520,6 @@ func (vm *FVM) ApplyImplicitMessage(ctx context.Context, cmsg *types.Message) (*
 		}
 	}
 
-	if ret.ExitCode != 0 {
-		return applyRet, fmt.Errorf("implicit message failed with exit code: %d and error: %w", ret.ExitCode, applyRet.ActorErr)
-	}
-
 	return applyRet, nil
 }