fix: v12: ComputeDataCommitment is deprecated #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
asr/deprecate
branch
from
826160f to
89f1bd8
Compare
magik6k
approved these changes
Oct 2, 2023
| @@ -17,7 +17,7 @@ var Methods = map[abi.MethodNum]builtin.MethodMeta{ | |||
| 5: {"VerifyDealsForActivation", *new(func(*VerifyDealsForActivationParams) *VerifyDealsForActivationReturn)}, // VerifyDealsForActivation | |||
| 6: {"ActivateDeals", *new(func(*ActivateDealsParams) *abi.EmptyValue)}, // ActivateDeals | |||
| 7: {"OnMinerSectorsTerminate", *new(func(*OnMinerSectorsTerminateParams) *abi.EmptyValue)}, // OnMinerSectorsTerminate | |||
| 8: {"ComputeDataCommitment", *new(func(*ComputeDataCommitmentParams) *ComputeDataCommitmentReturn)}, // ComputeDataCommitment | |||
| 8: {"ComputeDataCommitment", nil}, // deprecated | |||
There was a problem hiding this comment.
Do we also want to change this string to DeprecatedSomethingSomething? I'm fine with either way.
There was a problem hiding this comment.
It looks like that's not what we currently do, so let's stick with the current convention for now.
Stebalien
force-pushed
the
asr/deprecate
branch
from
89f1bd8 to
fc8c3f6
Compare
jennijuju
pushed a commit
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in filecoin-project/builtin-actors#1354