Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ComputeDataCommitment from built-in market #1354

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

anorth
Copy link
Member

@anorth anorth commented Aug 7, 2023

Note this is based on master, but I could rebase on integration/direct-onboarding if desired.

@anorth anorth requested a review from ZenGround0 August 7, 2023 22:36
@anorth anorth marked this pull request as ready for review August 7, 2023 22:36
@anorth anorth force-pushed the anorth/compute-commd branch from f1300dd to 727811f Compare August 8, 2023 01:43
@codecov-commenter
Copy link

Codecov Report

Merging #1354 (727811f) into master (ad4470f) will decrease coverage by 0.60%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
- Coverage   90.81%   90.21%   -0.60%     
==========================================
  Files         144      144              
  Lines       27346    27457     +111     
==========================================
- Hits        24834    24771      -63     
- Misses       2512     2686     +174     
Files Changed Coverage Δ
actors/market/src/lib.rs 79.28% <ø> (-13.22%) ⬇️
actors/market/src/types.rs 62.22% <ø> (-34.66%) ⬇️
actors/miner/src/ext.rs 67.74% <ø> (+4.10%) ⬆️

... and 3 files with indirect coverage changes

// Copyright 2019-2022 ChainSafe Systems
// SPDX-License-Identifier: Apache-2.0, MIT

use fil_actor_market::{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the market actor method passes most interesting functionality to the compute_data_commitment free function that's still in use it might be worth keeping some of these around in some form to test the free function.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had checked the compute_data_commitment free function and it's too trivial to test, just a call through to runtime (which in these unit tests is a mock anyway).

@anorth anorth added this pull request to the merge queue Aug 8, 2023
@anorth anorth removed this pull request from the merge queue due to a manual request Aug 8, 2023
@anorth anorth added this pull request to the merge queue Aug 8, 2023
Merged via the queue into master with commit 4d02c0c Aug 8, 2023
@anorth anorth deleted the anorth/compute-commd branch August 8, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants