Chore/tentative master m1 merge #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove wrong peer check in push deal validation * kill the pull side of peer id checking as well * fixup comments
* support padding out smaller files * Actually write out the padding - AP depends on it Co-authored-by: Peter Rabbitson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## feat/wip-markets-dagstore #590 +/- ##
=============================================================
- Coverage 66.37% 66.23% -0.14%
=============================================================
Files 63 63
Lines 4487 4503 +16
=============================================================
+ Hits 2978 2982 +4
- Misses 1228 1238 +10
- Partials 281 283 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should work ( let's see if github is smart enough... )