Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hex-encode CIDs in logs #561

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Do not hex-encode CIDs in logs #561

merged 2 commits into from
Jul 23, 2021

Conversation

ribasushi
Copy link
Contributor

No description provided.

@ribasushi ribasushi requested a review from dirkmc June 28, 2021 16:04
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, quite a bit more helpful, lol

@ribasushi ribasushi merged commit f15eef9 into master Jul 23, 2021
@ribasushi ribasushi deleted the chore/fix_cid_in_log branch July 23, 2021 19:34
aarshkshah1992 pushed a commit that referenced this pull request Jul 26, 2021
* remove wrong peer check in push deal validation (#585)

* remove wrong peer check in push deal validation

* kill the pull side of peer id checking as well

* fixup comments

* Do not hex-encode CIDs in logs (#561)

* On overloaded CI 10 seconds just isn't enough (#587)

* support padding out smaller files (#536)

* support padding out smaller files

* Actually write out the padding - AP depends on it

Co-authored-by: Peter Rabbitson <[email protected]>

Co-authored-by: Whyrusleeping <[email protected]>
Co-authored-by: Raúl Kripalani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants