Capture broadcasted messages for re-broadcasting even at panic #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
- Coverage 79.73% 79.37% -0.37%
==========================================
Files 52 52
Lines 4644 4674 +30
==========================================
+ Hits 3703 3710 +7
- Misses 584 604 +20
- Partials 357 360 +3
|
Stebalien
approved these changes
Sep 5, 2024
| return err | ||
| // Silently log the error and proceed. This is consistent with the behaviour of | ||
| // instance for regular broadcasts. | ||
| i.log("failed to request rebroadcast %s at round %d: %v", mb.Payload.Step, mb.Payload.Round, err) |
There was a problem hiding this comment.
Hm... it would be nice to sleep and/or backoff a little. But I guess that's a bit difficult.
There was a problem hiding this comment.
We might be able to use a simple circuit breaker at higher level (e.g. f3) to cover this. Updated the issue description.
Fix a bug where if `Host.RequestBroadcast` panics the requested message is never added to the re-broadcast state. Fix an inconsistent behaviour where error at requested broadcasts via re-broadcast are returned instead of being silently logged. Enhance emulator to allow pluggable signign logic with two additional signing implementation: erroneous and panic. Implement tests that assert expected behaviour at signing error or panic. Fixes #236
masih
force-pushed
the
masih/test-bad-signers
branch
from
c2a9bc4
to
fb9fe20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where if
Host.RequestBroadcastpanics the requested message is never added to the re-broadcast state.Fix an inconsistent behaviour where error at requested broadcasts via re-broadcast are returned instead of being silently logged.
Enhance emulator to allow pluggable signign logic with two additional signing implementation: erroneous and panic.
Implement tests that assert expected behaviour at signing error or panic.
Fixes #236