Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing misbehaving signer #236

Closed
Tracked by #249
Stebalien opened this issue May 16, 2024 · 1 comment · Fixed by #627
Closed
Tracked by #249

Testing misbehaving signer #236

Stebalien opened this issue May 16, 2024 · 1 comment · Fixed by #627
Assignees
@masih
Labels
testing Related to testing and validation
Milestone
Milestone 2: F3 H...

Comments

@Stebalien
Copy link
Member

We should test what happens if we have a "faulty" client (lotus) that fails and/or refuses to sign messages (e.g., miner gets restarted, etc.).
@Stebalien Stebalien added the testing Related to testing and validation label May 16, 2024
@masih
Copy link
Member

masih commented May 17, 2024

What's the specific scenario you have in mind?
What part do you think is not already covered by this test?

@masih masih mentioned this issue May 17, 2024
Closed
@masih masih self-assigned this Sep 4, 2024
masih added a commit that referenced this issue Sep 4, 2024
@masih
Capture broadcasted messages for re-broadcasting even at panic
c2a9bc4 
Fix a bug where if `Host.RequestBroadcast` panics the requested message
is never added to the re-broadcast state.

Fix an inconsistent behaviour where error at requested broadcasts via
re-broadcast are returned instead of being silently logged.

Enhance emulator to allow pluggable signign logic with two additional
signing implementation: erroneous and panic.

Implement tests that assert expected behaviour at signing error or
panic.

Fixes #236
@masih masih mentioned this issue Sep 4, 2024
Merged
masih added a commit that referenced this issue Sep 5, 2024
@masih
Capture broadcasted messages for re-broadcasting even at panic
fb9fe20 
Fix a bug where if `Host.RequestBroadcast` panics the requested message
is never added to the re-broadcast state.

Fix an inconsistent behaviour where error at requested broadcasts via
re-broadcast are returned instead of being silently logged.

Enhance emulator to allow pluggable signign logic with two additional
signing implementation: erroneous and panic.

Implement tests that assert expected behaviour at signing error or
panic.

Fixes #236
github-merge-queue bot pushed a commit that referenced this issue Sep 5, 2024
@masih
Capture broadcasted messages for re-broadcasting even at panic (#627)
de3c18e 
Fix a bug where if `Host.RequestBroadcast` panics the requested message
is never added to the re-broadcast state.

Fix an inconsistent behaviour where error at requested broadcasts via
re-broadcast are returned instead of being silently logged.

Enhance emulator to allow pluggable signign logic with two additional
signing implementation: erroneous and panic.

Implement tests that assert expected behaviour at signing error or
panic.

Fixes #236
@masih masih closed this as completed in #627 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
testing Related to testing and validation
Projects
F3
Status: Done
Milestone
Milestone 2: F3 Hardening and Mainnet...
Development

Successfully merging a pull request may close this issue.

Capture broadcasted messages for re-broadcasting even at panic filecoin-project/go-f3
4 participants
@masih @Stebalien @rjan90 @jennijuju