Raise market allowance infinite constant #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
force-pushed
the
feat/bigger-infinity
branch
from
e927db8 to
867db43
Compare
anorth
approved these changes
Sep 11, 2022
| static ref INFINITE_ALLOWANCE: TokenAmount = TokenAmount::from_whole(2_000_000_000); | ||
| static ref INFINITE_ALLOWANCE: TokenAmount = TokenAmount::from_atto( | ||
| BigInt::from(1_000_000_000_000_000_000_i64) | ||
| * BigInt::from(1_000_000_000_000_000_000_000_i128) |
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Jan 31, 2023
* Raise infinite constant * Remove testing of more complex behavior Co-authored-by: zenground0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand the way datacap works with the TokenAmount type it is 1) measured in units of bytes 2) measured at a base level of atto bytes when tokenized. That is a token amount of 10^18 should represent one byte.
If these assumptions are correct then the recent infinite limit is not actually that big ~GBs. This PR changes it to ~1000 EiB. Unfortunately
TokenAmount::from_wholetakes i64 not i128 so creating this constant is now messy.