Change TokenAmount::from_whole to take any Into<BigInt> parameter #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Stebalien should I pull into release/v2 branch after this ? |
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
==========================================
+ Coverage 51.27% 51.29% +0.02%
==========================================
Files 123 123
Lines 10065 10061 -4
==========================================
Hits 5161 5161
+ Misses 4904 4900 -4
|
Stebalien
approved these changes
Sep 12, 2022
|
Merged and backported (I was cutting a release anyways). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explicit
u64has been annoying downstream many times. Happily it should require no change in existing callers that pass u64.FYI @ZenGround0