Duplicate fvm_shared::actor::builtin::Type into runtime::builtins::Type #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies the builtin actor
Type
enum out of the FVM SDK into the built-in actors repo.Breaking coupling is necessary to enable development of the built-in actors (e.g. adding a new one) without depending on changes to the FVM SDK. Since the FVM doesn't want to depend on the actors, any changes to the enum need to be propagated to the FVM.
This removes all but one reference to the path
fvm_shared::actor
, the holdout being the conversion between the twoType
enums at the SDK syscall. This last one should be removed by changing the SDK to pass through the bare i32 value that it wrapped.Closes #520.