Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple actor Type enum from the FVM #520

Closed
anorth opened this issue Aug 12, 2022 · 0 comments · Fixed by #547
Closed

Decouple actor Type enum from the FVM #520

anorth opened this issue Aug 12, 2022 · 0 comments · Fixed by #547
Assignees
Labels

Comments

@anorth
Copy link
Member

anorth commented Aug 12, 2022

The built-in actors have a coupling to some FVM internals through the existence of a Type enum over the built-ins. This prevents adding new ones without making changes in FVM first. This blocks development of the datacap token and FIL+ claim actors for FIL+ decoupling.

Current proposal for fixing this is to drop the import and just copy the Type codes into the builtin-actors repo (with a mapping from syscall results at the runtime). This would introduce a bit of duplication to FVM, but pretty scoped. We can propagate the changes there after development.

Long term we should hope to remove this concept entirely. Most of the uses are anachronistic or can be expressed another way (e.g. use singleton addresses, look up miners in power actor state)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
1 participant