chore: remove support of v1 proofs in Miner actor #1391
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1391 +/- ##
==========================================
+ Coverage 91.00% 91.04% +0.03%
==========================================
Files 145 145
Lines 27529 27485 -44
==========================================
- Hits 25053 25023 -30
+ Misses 2476 2462 -14
|
| @@ -358,30 +358,24 @@ impl ProofSet { | |||
| /// Create a `ProofSet` for enabled `RegisteredPoStProof`s | |||
| pub fn default_post_proofs() -> Self { | |||
| let mut proofs = vec![false; REGISTERED_POST_PROOF_VARIANTS]; | |||
There was a problem hiding this comment.
We should be able to drop the size of this REGISTERED_POST_PROOF_VARIANTS field now.
There was a problem hiding this comment.
What do you mean exactly by dropping the size of REGISTERED_POST_PROOF_VARIANTS?
There was a problem hiding this comment.
I think the number can change from 15 to 10?
There was a problem hiding this comment.
You mean from 15 to 5, no? Let me know if I am mistaken, I might not have all the context here.
I have also created counterpart PR in the FVM repo: filecoin-project/ref-fvm#1896
There was a problem hiding this comment.
Oh, nvm, I was wrong -- we can't reduce this number at all, because it needs to be indexed up to StackedDRGWindow64GiBV1P1, which is 15.
There was a problem hiding this comment.
Yes but once the builtin-actors repo is making use of FVM4 this should be possible (the V1P1 proofs are indexed from 0 to 4 there).
There was a problem hiding this comment.
Unfortunately, these numbers are consensus-critical, so we can't change them (easily).
We were supporting partially v1 PoSt proof types in v11, now we don't support them anymore in v12.
Q: Do we need to remove v1 variants in
RegisteredPoStProofaltogether?Closes #1260