Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miner v12: cleanup: drop all support for v1 window PoSt proof types #1260

Closed
Tracked by #1274
arajasek opened this issue Mar 27, 2023 · 2 comments · Fixed by #1391
Closed
Tracked by #1274

Miner v12: cleanup: drop all support for v1 window PoSt proof types #1260

arajasek opened this issue Mar 27, 2023 · 2 comments · Fixed by #1391
Assignees
Labels
good first issue Good for newcomers P2

Comments

@arajasek
Copy link
Contributor

There is partial support for v1 PoSt proof types in v11 that must be dropped in v12. Specifically, we must:

  • Remove v1 proof types from the policy's valid_post_proof_type
  • Remove special-case checks in the miner constructor
  • Remove the special v19 check in submit_windowed_post that allows for v1 proof types to be submitted in v19
@jennijuju jennijuju added this to the 2023 Actor 🧹 milestone Apr 3, 2023
@ZenGround0 ZenGround0 added the good first issue Good for newcomers label May 9, 2023
@jennijuju
Copy link
Member

This is a nice to have for nv21/ actor v12 (and in general we should avoid keep postponing clean ups).

@jennijuju
Copy link
Member

@elmattic thank you for taking this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P2
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants