extract VM trait to it's own crate #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
- Coverage 90.75% 84.04% -6.71%
==========================================
Files 139 143 +4
Lines 27343 29264 +1921
==========================================
- Hits 24814 24596 -218
- Misses 2529 4668 +2139
|
alexytsu
force-pushed
the
alexytsu/export-test-vm
branch
from
fb14d19 to
27b175f
Compare
anorth
approved these changes
Jul 28, 2023
|
|
||
| use cid::Cid; | ||
| use fil_actors_runtime::runtime::{builtins::Type, Primitives}; | ||
| // TODO: drop the dependency on fil_actors_runtime and have a suitable replacement abstraction here | ||
| pub use fil_actors_runtime::runtime::{builtins::Type, Primitives}; |
There was a problem hiding this comment.
The VM just uses a u32. That might be sufficient here.
For Primitives maybe we need a new trait which will duplciate that, but also add in the externs. Basically the stuff thatneeds to be injected into any VM from the outside.
Please file an issue for the TODO and reference it here. I trust you'll follow up shortly here.
Merged
alexytsu
force-pushed
the
alexytsu/export-test-vm
branch
from
27b175f to
77c30c3
Compare
alexytsu
force-pushed
the
alexytsu/export-test-vm
branch
from
77c30c3 to
b1ee35d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1327
No code changes are made in this PR apart from a relocation of the shared VM trait and associated utils/types into a separate crate.