-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VM trait #1340
Merged
Merged
Update VM trait #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
- Coverage 90.84% 90.79% -0.06%
==========================================
Files 138 139 +1
Lines 27350 27351 +1
==========================================
- Hits 24847 24832 -15
- Misses 2503 2519 +16
|
alexytsu
force-pushed
the
alexytsu/update-vm-trait
branch
from
July 27, 2023 06:58
845b047
to
97b837d
Compare
anorth
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There's some deconflicting to do with #1343 and follow up to cut clean deps, but that looks easy enough from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some methods that were previously on the abstract VM are deemed specific to the implementation of the TestVM in builtin-actors. To ease alignment with VM implementations in other contexts such as https://github.com/anorth/fvm-workbench, certain methods have been removed from the trait such as those relating to builtin-actors' notion of
Policy
and actor manifest.