Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .prettierignore file #718

Closed
AlecRust opened this issue Mar 22, 2018 · 3 comments · Fixed by #720
Closed

Support for .prettierignore file #718

AlecRust opened this issue Mar 22, 2018 · 3 comments · Fixed by #720
Labels
filetype-support New file-extensions or filename patterns associated with an existing icon.

Comments

@AlecRust
Copy link

What do you think about using the Prettier logo (or a faded version like ESLint) for .prettierignore files?

screenshot

@Alhadis
Copy link
Member

Alhadis commented Mar 22, 2018

Seems like a good idea. You wanna file a PR for this or should I do it? 😉

I don't use Prettier, so there might be other Prettier-relevant filenames I'm completely oblivious of.

@AlecRust
Copy link
Author

Happy to look at it, new to this project though. For example are there any colour shading rules around primary (eslintrc.json/.prettierrc) vs secondary (.eslintignore/.prettierignore) config file icons like the above screenshot might suggest?

@Alhadis
Copy link
Member

Alhadis commented Mar 22, 2018

Nope. Generally, we use colours used by the icon's official branding. Additional filetypes using that icon tend to vary in that shade simply because they're colours pulled from the icon's styleguide. Since the project's colour palette is limited to ~27 swatches, there's only so much variation of icon-colours we can do before shit just gets fully-random. 😅

Alhadis added a commit that referenced this issue May 19, 2018
It's unlikely caktux/language-ethereum#13 will ever be merged, since the
package appears well-and-truly abandoned by its author.

References: #708, #718
@Alhadis Alhadis added the filetype-support New file-extensions or filename patterns associated with an existing icon. label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filetype-support New file-extensions or filename patterns associated with an existing icon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants