Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly styled font with every Ruby file #739

Closed
Vincentdc94 opened this issue May 19, 2018 · 2 comments
Closed

Incorrectly styled font with every Ruby file #739

Vincentdc94 opened this issue May 19, 2018 · 2 comments
Labels
duplicate Duplicate of an already-reported issue. upstream-issue Valid issue, wrong package. Stuff that file-icons has no control or responsibility over.

Comments

@Vincentdc94
Copy link

Hello there,
I found a bug in your extension and researched a bit already for you guys.

Clearly the text behind the icon doesn't match the font it should show.
Incorrectly renderend fonts

I went on research and unchecked these two style rules, and the fonts where styled correctly.
Css rules that cause the problem

The result was as it should be as you see on the image below
This is how it should be

I tried to look in the code but didn't find a direct solution. I only checked the .less files tough and I have to work on the project that is open in atom so I only spend a few minutes and decided to post it here.

Extra info

  • I run Ubuntu 18.04 64bit, Gnome 3
  • Atom version is 1.26.1
  • File icons extension version is 2.1.21 but the issue was already present in previous version.

If you need any other info, feel free to ask! I hope this will already help you further.

@Alhadis
Copy link
Member

Alhadis commented May 19, 2018

Uninstall language-etherum. It's a known issue with that particular package.

Its author has been contacted to merge an upstream pull-request, but there's been no response. The only solution is to use another package for Ethereum highlighting.

@Alhadis Alhadis closed this as completed May 19, 2018
@Alhadis
Copy link
Member

Alhadis commented May 19, 2018

I'm actually going to update the troubleshooting docs to explain this, because you're not the first person to report this. I doubt you'll be the last, either...

@Alhadis Alhadis added the duplicate Duplicate of an already-reported issue. label May 19, 2018
Alhadis added a commit that referenced this issue May 19, 2018
It's unlikely caktux/language-ethereum#13 will ever be merged, since the
package appears well-and-truly abandoned by its author.

References: #708, #718
@Alhadis Alhadis added blocked Unable to address issue until actions are taken elsewhere (e.g., merging a pull-request). upstream-issue Valid issue, wrong package. Stuff that file-icons has no control or responsibility over. and removed blocked Unable to address issue until actions are taken elsewhere (e.g., merging a pull-request). labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Duplicate of an already-reported issue. upstream-issue Valid issue, wrong package. Stuff that file-icons has no control or responsibility over.
Projects
None yet
Development

No branches or pull requests

2 participants