Do not delete properties from option maps. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey guys! Any feedback on this? We kind of need this merged :). |
mfilenko
added a commit
that referenced
this pull request
Feb 23, 2016
Keep the `options` object in case of request failure.
|
Sorry to be a pain. But could you guys publish this to npm also :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a problem while using your module.
When asking for a list of transactions, this can fail because of an access token, which means it is often needed to retry. When I do this retry, I reuse the same options map I pass to the
get_transactionsfunction, but because theaccount_idproperty is removed from this object, the second time I try the filtering by account is not done.This clones the options map, so that the
account_idis deleted from a copy and not from the original object.