Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use built-ins when possible #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use built-ins when possible #43

wants to merge 2 commits into from

Conversation

mfilenko
Copy link
Contributor

Follow-up on #8: use standard JSON methods to deep clone options object.

This will also eliminate outdated dependency issue:

screen shot 2017-08-13 at 20 55 17

makst
makst approved these changes Nov 14, 2018
View reviewed changes
Copy link

@makst makst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeremyCraigMartinez
JeremyCraigMartinez approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@JeremyCraigMartinez JeremyCraigMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge ‘er ol’ boy, it’s time 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyCraigMartinez JeremyCraigMartinez JeremyCraigMartinez approved these changes

@makst makst makst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfilenko @makst @JeremyCraigMartinez