Fix warnings from GHA checks #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Script to identify upgradeable patterns based on their number of Known Instances * Formatting changes to the 'Known Instances' section of some patterns. Allows for easier scanning of the new find_upgradeable_patterns.rb script
…as a term, changed formatting, shortened name (InnerSourceCommons#409) * Moved to InnerSource as a term, changed formatting, shortened name I believe this pattern does need a bit of love. I only made some first changes to the name "InnerSource", changed some formatting and shortened the name. However I believe the solutions given are incomplete in particular wrt. build chain solutions to the issue. It might make sense to mention explicit release naming and numbering schemes. It might make sense to mention the option of setting up build systems to trigger new builds on upstream code changes or upstream releases. * Spell out definition of SCM and add a link --------- Co-authored-by: Sebastian Spier <[email protected]>
* Add vale. * Fixes to the spelling, discovered by our new spellchecker. Mostly fixes in the Structured patterns, some for the Initial patterns as well. * Move config for pattern syntax linting to .github * Explain spellchecking approach in the Contributor Handbook
* Board Report 2023-05
…SourceCommons#550) Airbus switched from SAP portal to Backstage/Bazaar as Backstage is becoming the standard internally
Co-authored-by: tomoyuki kobayashi <[email protected]>
Co-authored-by: tomoyuki kobayashi <[email protected]>
LGTM です! Co-authored-by: tomoyuki kobayashi <[email protected]>
Co-authored-by: tomoyuki kobayashi <[email protected]>
Co-authored-by: tomoyuki kobayashi <[email protected]>
Co-authored-by: bakisunsan <[email protected]>
Create COMMUNICATION-template.md - Creating template so I have link to add to the base documentation pattern when I add the template to it. --------- Co-authored-by: Sebastian Spier <[email protected]>
Co-authored-by: tomoyuki kobayashi <[email protected]>
Co-authored-by: tomoyuki kobayashi <[email protected]>
…ing-extensions-for-sustainable-growth-ja-translation Japanese Translation - Extensions for Sustainable Growth Pattern
* Use glob to select files to be checked by vale * Removing GH token * Remove unused gitignore rule * Adding debug flag, to increase inspectability of vale output in future GHA runs
…ceCommons#558) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Adding configuration for the welcome bot. * Update link to the ISC slack instance. * Stop checking link to chatham house rule (as it always gets reported as broken, even though it is not).
Move Release Process to structured by doing various changes: * Update title * Update problem category (in the mindmap). Also added Standard Base Documentation to this new problem category. * Updates to Context and Force. Plus a few grammar clean ups * Update Patlet * Restructure Problem and Context
…aded to Structured. (InnerSourceCommons#574)
This also fixes an issue reported by 'Link Check PR'. Merge branch 'main' into adding-new-feature-owner-pattern
|
Thank you!Thanks,ManojOn Aug 16, 2023, at 5:34 PM, Sebastian Spier ***@***.***> wrote:Hi @magawande,
this PR is doing two things:
patching your branch with any changes that happened to InnerSourcePatterns:main since you branched out (this was a couple of months ago, so just want to make sure that we had no possible merge conflicts here)
fixing a link found by Link Check PR
making some changes so that the "Spelling & Styles" won't trhow warnings on the author names in your new pattern any more
Btw I had to us this "fork from your fork" approach as GitHub doesn't allow me to push to branches created on an organization-owned fork. Learned something new today!
Once your merge this PR, the checks on InnerSourceCommons#573 should run again, and will hopefully all be green then.
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
6f457ff Script to find upgradeable patterns (#534)
5c3eb97 shared-code-repo-different-from-build-repo.md - Moved to InnerSource as a term, changed formatting, shortened name (#409)
903c68c Removing link to innersourceportal.santander.com (#539)
1d27905 Adding vale for spell and style checking (#519)
59c01a9 Writing updated files for the book
db15ee1 Board Report 2023-05 (#540)
4afeec8 Fixing link (#545)
9635fc4 Re-creating markmap and screenshot
b27512e Add i18n consistency-checker
fccd62b Update to use i18n label for internationalization related issue
55cbbc9 Initial Japanese Translation - extensions-for-sustainable-growth pattern
2ccf254 Update links
59b5a11 Update the wiki link to pass the link check
94a5aae Update Label Type - i18n-consistency-checker.yaml
845cb29 Update Airbus implementation of the innersource portal pattern (#550)
279c99f Update translation/ja/patterns/extensions-for-sustainable-growth.md
9abad41 Update translation/ja/patterns/extensions-for-sustainable-growth.md
32f2860 Update translation/ja/patterns/extensions-for-sustainable-growth.md
6c4c03f Update translation/ja/patterns/extensions-for-sustainable-growth.md
9941e90 Update translation/ja/patterns/extensions-for-sustainable-growth.md
0266cca Incorporated the review
ab1cce3 Update Japanese translation
11bc7eb Update base-documentation.md, fix CONTRIBUTING spelling (#552)
243f4bc Create COMMUNICATION-template.md (#557)
e936f17 Add Known Instance to service-vs-library.md (#559)
a171116 Update translation/ja/patterns/extensions-for-sustainable-growth.md
cc8dc8f Update translation/ja/patterns/extensions-for-sustainable-growth.md
506cebf Merge pull request #549 from InnerSourceCommons/adding-extensions-for-sustainable-growth-ja-translation
44fab36 Add Mercedes-Benz as known instance to innersource-portal.md (#561)
516a887 Use glob to select files to be checked by vale (#541)
ac724fc Bump semver from 5.7.1 to 5.7.2 in /pattern-categorization (#558)
370cc98 Adding welcome bot + fix links to slack (#567)
9c3697a Move Release Process pattern to L2 (Structured) (#524)
3a50380 Writing updated files for the book
7aa4e06 Add GitHub to release-process as a known instance (#568)
d8f253c Re-creating markmap and screenshot
e744a71 Remove outdated link to 'release process' pattern. this has been upgraded to Structured. (#574)
84aac4f As this branch was far behind main, I am bringing in the latest changes.
75327fb Switch to AE spelling
92e13ac Prefent spell checker warnings on author names
File Changes (65 files)
M
.github/ISSUE_TEMPLATE/config.yml
(2)
A
.github/config.yml
(44)
R
.github/lint-pattern-syntax/pattern-template.js
(0)
R
.github/lint-pattern-syntax/pattern-template.yml
(0)
A
.github/vale/Vocab/Base/accept.txt
(6)
A
.github/vale/Vocab/Base/reject.txt
(0)
A
.github/workflows/i18n-consistency-checker.yaml
(104)
M
.github/workflows/lint-patterns.yml
(8)
A
.github/workflows/vale.yml
(26)
A
.gitignore
(2)
M
.lycheeignore
(3)
A
.vale.ini
(12)
M
CONTRIBUTING.md
(2)
M
README.md
(8)
M
book/en/toc.md
(5)
M
meta/FAQ.md
(2)
M
meta/README.md
(1)
M
meta/boardreports/2023-02.md
(2)
A
meta/boardreports/2023-05.md
(109)
M
meta/contributor-handbook.md
(2)
M
meta/pattern-template.md
(2)
A
meta/scripts/Gemfile
(7)
A
meta/scripts/find_upgradeable_patterns.rb
(84)
M
pattern-categorization/innersource-program-mind-map.html
(2)
M
pattern-categorization/innersource-program-mind-map.md
(6)
M
pattern-categorization/innersource-program-mind-map.png
(0)
M
pattern-categorization/package-lock.json
(84)
M
patterns/1-initial/crossing-chasm.md
(2)
M
patterns/1-initial/discover-your-innersource.md
(2)
M
patterns/1-initial/explicit-shared-ownership.md
(4)
M
patterns/1-initial/governance-levels.md
(16)
M
patterns/1-initial/incubator-pipeline.md
(2)
M
patterns/1-initial/innersource-guidance-group.md
(2)
M
patterns/1-initial/innersource-portal-hygiene.md
(6)
M
patterns/1-initial/introducing-metrics-in-innersource.md
(2)
M
patterns/1-initial/not-invented-here.md
(4)
D
patterns/1-initial/release-process.md
(51)
M
patterns/1-initial/shared-code-repo-different-from-build-repo.md
(12)
M
patterns/2-structured/30-day-warranty.md
(2)
M
patterns/2-structured/common-requirements.md
(4)
M
patterns/2-structured/contracted-contributor.md
(8)
M
patterns/2-structured/core-team.md
(6)
M
patterns/2-structured/crossteam-project-valuation.md
(12)
M
patterns/2-structured/dedicated-community-leader.md
(4)
M
patterns/2-structured/document-your-guiding-principles.md
(46)
M
patterns/2-structured/feature-owners.md
(2)
M
patterns/2-structured/innersource-license.md
(2)
M
patterns/2-structured/innersource-portal.md
(8)
M
patterns/2-structured/maturity-model.md
(14)
M
patterns/2-structured/praise-participants.md
(2)
M
patterns/2-structured/project-setup/base-documentation.md
(4)
M
patterns/2-structured/project-setup/communication-tooling.md
(4)
A
patterns/2-structured/project-setup/templates/COMMUNICATION-template.md
(73)
M
patterns/2-structured/project-setup/templates/CONTRIBUTING-template.md
(4)
M
patterns/2-structured/project-setup/templates/README-template.md
(2)
A
patterns/2-structured/release-process.md
(69)
M
patterns/2-structured/repository-activity-score.md
(6)
M
patterns/2-structured/review-committee.md
(2)
M
patterns/2-structured/service-vs-library.md
(15)
M
patterns/2-structured/start-as-experiment.md
(2)
M
patterns/2-structured/templates/rfc.md
(4)
M
patterns/2-structured/transparent-cross-team-decision-making-using-rfcs.md
(4)
M
patterns/2-structured/trusted-committer.md
(2)
A
translation/ja/patterns/extensions-for-sustainable-growth.md
(113)
M
translation/ja/patterns/innersource-portal.md
(2)
Patch Links:
https://github.com/fidelity/InnerSourcePatterns/pull/2.patch
https://github.com/fidelity/InnerSourcePatterns/pull/2.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
magawande
merged commit ffd84d9
into
fidelity-contributions:adding-new-feature-owner-pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @magawande,
this PR is doing two things:
Btw I had to us this "fork from your fork" approach as GitHub doesn't allow me to push to branches created on an organization-owned fork. Learned something new today!
Once your merge this PR, the checks on InnerSourceCommons#573 should run again, and will hopefully all be green then.