Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for vue-tsc 2.0.1 #307

Closed
wants to merge 2 commits into from
Closed

Conversation

simensfo
Copy link

@simensfo simensfo commented Mar 6, 2024

resolves #306

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: 7d54d44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit 7d54d44
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/65e8555faab586000805f7fb
😎 Deploy Preview https://deploy-preview-307--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework
Copy link
Owner

fi3ework commented Mar 6, 2024

it's not easy to solve the issue by this way, vue-tsc 2 changed a lot. We need to figure out a new way to integrate with it.

@simensfo
Copy link
Author

simensfo commented Mar 6, 2024

I may be wrong, but based on the changelog there aren't really any breaking changes. If this plugin mostly just runs vue-tsc during build, then wouldn't it be enough to just import from the right place?

@armano2
Copy link
Contributor

armano2 commented Apr 1, 2024

build part should be working fine even without this change, issue is with what is done during "patching" of lib

i was generally thinking about this, and wdyt about using tsserver instead?
https://github.com/microsoft/TypeScript/wiki/Standalone-Server-(tsserver)

this patching for both typescript and vue seem to be an kinda an overkill

@simensfo simensfo closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stopped working with vue-tsc 2.0.1
3 participants